Skip to content

fix(deps): update DA dependencies + example / tests cleanup #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 26, 2025
Merged

fix(deps): update DA dependencies + example / tests cleanup #415

merged 9 commits into from
Sep 26, 2025

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Sep 18, 2025 •
edited
Loading

Description

  • updated DA dependencies to latest
  • Renamed complete example to advanced
  • Example cleanup
  • Tests cleanup

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh marked this pull request as draft September 18, 2025 20:00
shemau
shemau previously approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh marked this pull request as ready for review September 19, 2025 14:43
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

The test has found some valid bugs here when using existing instance:

 2025/09/19 20:18:11 Terraform plan | Error: Invalid value for variable
 2025/09/19 20:18:11 Terraform plan | 
 2025/09/19 20:18:11 Terraform plan |   on schematics.tfvars line 14:
 2025/09/19 20:18:11 Terraform plan |   14: existing_kms_instance_crn = "crn:v1:bluemix:public:kms:us-south:a/abac0df06b644a9cabc6e44f55b3880e:359a4ce9-a149-414b-8106-192bf77fa905::"
 2025/09/19 20:18:11 Terraform plan |     ├────────────────
 2025/09/19 20:18:11 Terraform plan |     │ var.existing_kms_instance_crn is "crn:v1:bluemix:public:kms:us-south:a/abac0df06b644a9cabc6e44f55b3880e:359a4ce9-a149-414b-8106-192bf77fa905::"
 2025/09/19 20:18:11 Terraform plan |     │ var.existing_secrets_manager_crn is "crn:v1:bluemix:public:secrets-manager:eu-gb:a/abac0df06b644a9cabc6e44f55b3880e:69252e61-187a-46e0-a4aa-ed2c1863f93c::"
 2025/09/19 20:18:11 Terraform plan | 
 2025/09/19 20:18:11 Terraform plan | A value should not be passed for 'existing_kms_instance_crn' when passing an
 2025/09/19 20:18:11 Terraform plan | existing secrets manager instance using the 'existing_secrets_manager_crn'
 2025/09/19 20:18:11 Terraform plan | input.
 2025/09/19 20:18:11 Terraform plan | 
 2025/09/19 20:18:11 Terraform plan | This was checked by the validation rule at variables.tf:208,3-13.
 2025/09/19 20:18:11 Terraform plan | 
 2025/09/19 20:18:11 Terraform plan | Error: Invalid function argument
 2025/09/19 20:18:11 Terraform plan | 
 2025/09/19 20:18:11 Terraform plan |   on variables.tf line 71, in variable "service_plan":
 2025/09/19 20:18:11 Terraform plan |   71:     condition     = contains(["standard", "trial"], var.service_plan)
 2025/09/19 20:18:11 Terraform plan |     ├────────────────
 2025/09/19 20:18:11 Terraform plan |     │ while calling contains(list, value)
 2025/09/19 20:18:11 Terraform plan |     │ var.service_plan is null

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh mentioned this pull request Sep 23, 2025
Merged
6 tasks
@ocofaigh
Copy link
Contributor Author

Need to wait for this fix: terraform-ibm-modules/ibmcloud-terratest-wrapper#1041

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 17f47a8 into main Sep 26, 2025
2 checks passed
@ocofaigh ocofaigh deleted the tests branch September 26, 2025 09:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajatagarwal-ibm rajatagarwal-ibm rajatagarwal-ibm approved these changes

@shemau shemau shemau left review comments

@alex-reiff alex-reiff Awaiting requested review from alex-reiff alex-reiff is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ocofaigh @terraform-ibm-modules-ops @shemau @rajatagarwal-ibm